This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Reliably track proc macro & build.rs code coverage #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #8210 +/- ##
========================================
+ Coverage 81.3% 81.3% +<.1%
========================================
Files 251 251
Lines 54039 54039
========================================
+ Hits 43955 43956 +1
+ Misses 10084 10083 -1 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2020
(cherry picked from commit 890919d)
|
@mvines Thanks for quick approval! :) |
solana-grimes
pushed a commit
that referenced
this pull request
Feb 11, 2020
This was referenced Nov 19, 2022
Open
Open
Open
Open
Open
Open
This was referenced Feb 4, 2023
This was referenced Feb 8, 2023
Open
Open
This was referenced Feb 11, 2023
This was referenced Feb 13, 2023
Open
This was referenced Feb 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Coverages for proc-macro and build.rs isn't reliable because these are executed at the compile-time, which can result in being skipped due to caches.
build.rsfiles incorrectly disappear even for this nano PR (+4 −5 changes) (https://codecov.io/gh/solana-labs/solana/pull/8199/changes, Fix nightly clippy warnings #8199 (comment))And, I'm obsessed just with coverages too much; But this is the final PR of my several-month-long journey to the perfect coverage tracking. After this, there should be no coverage issues whatsoever!!!
Summary of Changes
Disable caching for them by
touch-ing. Yes, build time will get slower butcoveragejob isn't longest to finish. :p Also, the number of affectedsolana-*crates are small compared to vast of other dependant crates.And, I'm relieved from unreliable coverages finally.
Background
In anticipation of #8012 (which introduces both moderate amount of proc macro and build.rs, which would disturbance other PRs after merged without this.)